SITES-15031 - [Regression] Encoded URL is decoded unintentionally and the URL doesn't work #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the URL doesn't work
Codecov Report
@@ Coverage Diff @@
## main #2564 +/- ##
============================================
+ Coverage 87.31% 87.33% +0.01%
- Complexity 2645 2646 +1
============================================
Files 232 232
Lines 7063 7072 +9
Branches 1071 1071
============================================
+ Hits 6167 6176 +9
Misses 359 359
Partials 537 537
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edoardo-goracci
approved these changes
Aug 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
LSantha
reviewed
Aug 3, 2023
|
|
||
| static { | ||
| PATTERNS.add(Pattern.compile("(<%[=@].*?%>)")); | ||
| PATTERNS.addAll(Arrays.stream(RESERVED_CHARACTERS_ENCODED) |
There was a problem hiding this comment.
@cioriia , why do we need a distinct regex pattern for each character?
LSantha
changed the title
LSantha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the URL encoding in DefaultPathProcessor .