Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing folder in integration tests #2618

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Nov 9, 2023

The integration tests added in #2604 may fail with

Caused by: javax.jcr.nodetype.ConstraintViolationException: No default node type available for /apps/core/config
	at org.apache.jackrabbit.oak.plugins.tree.TreeUtil.addChild(TreeUtil.java:232) [org.apache.jackrabbit.oak-security-spi:1.22.16]
	at org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:690) [org.apache.jackrabbit.oak-jcr:1.22.16]
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:321) [org.apache.jackrabbit.oak-jcr:1.22.16]
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:287) [org.apache.jackrabbit.oak-jcr:1.22.16]
	at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207) [org.apache.jackrabbit.oak-jcr:1.22.16]
	at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112) [org.apache.jackrabbit.oak-jcr:1.22.16]
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:287) [org.apache.jackrabbit.oak-jcr:1.22.16]
	at org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:265) [org.apache.jackrabbit.oak-jcr:1.22.16]
	at org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:451) [org.apache.sling.jcr.resource:3.0.18]

This PR adds the folder that is being created as sling:Folder.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2618 (a5654a7) into main (0efca91) will not change coverage.
The diff coverage is n/a.

❗ Current head a5654a7 differs from pull request most recent head 20188a8. Consider uploading reports for the commit 20188a8 to get more accurate results

@@            Coverage Diff            @@
##               main    #2618   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7080     7080           
  Branches       1073     1073           
=========================================
  Hits           6184     6184           
  Misses          359      359           
  Partials        537      537           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@buuhuu buuhuu requested a review from vladbailescu November 13, 2023 21:13
@vladbailescu vladbailescu merged commit 5156fbb into main Nov 14, 2023
15 checks passed
@vladbailescu vladbailescu deleted the SITES-16805-properly-init-rewiter-pipe-with-toc-filter-enabled branch November 14, 2023 08:16
@LSantha LSantha added this to the 2.24.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants