-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2606] Fixed Non-deterministic behavior of HashSet that might fail the test ClientLibrariesImplTest #2621
Merged
vladbailescu
merged 6 commits into
adobe:main
from
SaaiVenkat:improvement/fix-flaky-test-ClientLibrariesImplTest-testGetCategoriesWithInjectedResourceTypesAndInheritance
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents into improvement/fix-flaky-test-ClientLibrariesImplTest-testGetCategoriesWithInjectedResourceTypesAndInheritance
@vladbailescu Since you approved these changes here, I am raising this PR. |
SaaiVenkat
changed the title
Improvement/fix flaky test client libraries impl test test get categories with injected resource types and inheritance
Fixed Non-deterministic behavior of HashSet that might fail the test ClientLibrariesImplTest
Nov 18, 2023
SaaiVenkat
changed the title
Fixed Non-deterministic behavior of HashSet that might fail the test ClientLibrariesImplTest
[2606] Fixed Non-deterministic behavior of HashSet that might fail the test ClientLibrariesImplTest
Nov 18, 2023
…plTest-testGetCategoriesWithInjectedResourceTypesAndInheritance
vladbailescu
approved these changes
Dec 27, 2023
…plTest-testGetCategoriesWithInjectedResourceTypesAndInheritance
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
=========================================
Coverage 87.34% 87.34%
Complexity 2648 2648
=========================================
Files 232 232
Lines 7080 7080
Branches 1073 1073
=========================================
Hits 6184 6184
Misses 359 359
Partials 537 537 ☔ View full report in Codecov by Sentry. |
SaaiVenkat
deleted the
improvement/fix-flaky-test-ClientLibrariesImplTest-testGetCategoriesWithInjectedResourceTypesAndInheritance
branch
October 1, 2024 19:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2606
HashSet
causes the issue, we need to make it deterministic.categories
fromHashSet
toLinkedHashSet
.aem-core-wcm-components/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v1/ClientLibrariesImpl.java
Line 324 in 0efca91