OEmbedClientImpl leaks network connections #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandru-stancioiu
approved these changes
Apr 8, 2024
spopescu
approved these changes
Apr 8, 2024
|
kwin
reviewed
Apr 8, 2024
| } | ||
| HttpResponse response = httpClient.execute(new HttpGet(url)); | ||
| return response.getEntity().getContent(); |
There was a problem hiding this comment.
AFAIK accessing the response's input stream is no longer possible once the surrounding http client is closed.
One rather needs to deserialize it first, preferably via https://www.javadoc.io/doc/org.apache.httpcomponents/httpclient/4.3.2/org/apache/http/impl/client/CloseableHttpClient.html#execute(org.apache.http.HttpHost,%20org.apache.http.HttpRequest,%20org.apache.http.client.ResponseHandler)
There was a problem hiding this comment.
@kwin , you're right! @andreeadracea , that's also why the ITs are failing:
Test Result (7 failures / +6)
ITHttpTests.com.adobe.cq.wcm.core.components.it.http.ComponentsIT.testEmbed
E2ESeleniumTestsGroup3.com.adobe.cq.wcm.core.components.it.seljup.tests.embed.v1.EmbedIT.testUrlOEmbedYouTube
E2ESeleniumTestsGroup3.com.adobe.cq.wcm.core.components.it.seljup.tests.embed.v1.EmbedIT.testUrlOEmbedSoundCloud
E2ESeleniumTestsGroup3.com.adobe.cq.wcm.core.components.it.seljup.tests.embed.v1.EmbedIT.testUrlValidation
E2ESeleniumTestsGroup3.com.adobe.cq.wcm.core.components.it.seljup.tests.embed.v2.EmbedIT.testUrlOEmbedYouTube
E2ESeleniumTestsGroup3.com.adobe.cq.wcm.core.components.it.seljup.tests.embed.v2.EmbedIT.testUrlOEmbedSoundCloud
E2ESeleniumTestsGroup3.com.adobe.cq.wcm.core.components.it.seljup.tests.embed.v2.EmbedIT.testUrlValidation
See a proposed alternative in #2717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using try-with-resources in order to be sure the HttpClient connection will be closed after using it.
Fixes #1, Fixes #2