Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-21939] Alt Text not persisting in Page Properties for Featured Image #2759

Merged
merged 1 commit into from
May 28, 2024

Conversation

YahorC
Copy link
Contributor

@YahorC YahorC commented May 26, 2024

Adding additional check, in case we are opening dialog for Page component image section and in that case updating value of remoteFileReference in order to execute retrieveInstanceInfo correctly for page component and update alt text field in dialog

Q                       A
Fixed Issues? https://jira.corp.adobe.com/browse/SITES-22145
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@YahorC YahorC requested a review from a team May 26, 2024 22:16
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (d844a0e) to head (6b0b184).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2759   +/-   ##
=========================================
  Coverage     87.17%   87.17%           
  Complexity     2683     2683           
=========================================
  Files           235      235           
  Lines          7166     7166           
  Branches       1094     1094           
=========================================
  Hits           6247     6247           
  Misses          363      363           
  Partials        556      556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YahorC YahorC merged commit bfc2bd6 into main May 28, 2024
14 checks passed
@YahorC YahorC deleted the SITES-21939 branch May 28, 2024 08:10
@vladbailescu vladbailescu added this to the 2.26.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants