[SITES-22419] Follow up on SITES-19714 Fix Release #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
============================================
+ Coverage 87.17% 87.21% +0.03%
- Complexity 2683 2687 +4
============================================
Files 235 235
Lines 7166 7170 +4
Branches 1094 1096 +2
============================================
+ Hits 6247 6253 +6
Misses 363 363
+ Partials 556 554 -2 ☔ View full report in Codecov by Sentry. |
myronenko
approved these changes
Jun 25, 2024
RaduADumitru
approved these changes
Jun 25, 2024
|
@YahorC , could you please add at least one unit test case for your fix, possibly using somewhat realistic path values like the ones mentioned in the ticket? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2(https://jira.corp.adobe.com/browse/SITES-22419) Jira issue.
Adding this check, in order to get false result, when we have current page language code longer then from another list of pages (for example because of previous implementation when we have 2 under root with names zh and zh_cm component wont be able to show link to second one)