-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consistent variadic argument support in all loggers #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 134 132 -2
Branches 22 24 +2
=========================================
- Hits 134 132 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(Also TIL I am a mountain climber ⛰️ )
d'oh! it was a nice exercise, but I just realized I was just re-implementing node:util.format 😱 Reworking this PR |
Fixed 😅 (build failures because of eslint-plugin-import 2.27.0, which is pending a patch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! (and learned about util.format
myself 🙂 )
Closes #21 - however since it is using util.inspect, there is no indenting of json objects
Closes #16
How Has This Been Tested?
npm test
Types of changes
Checklist: