Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent variadic argument support in all loggers #36

Merged
merged 8 commits into from
Jan 18, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 11, 2023

Closes #21 - however since it is using util.inspect, there is no indenting of json objects
Closes #16

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #36 (7d1852a) into master (5b48433) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          134       132    -2     
  Branches        22        24    +2     
=========================================
- Hits           134       132    -2     
Impacted Files Coverage Δ
src/AioLogger.js 100.00% <100.00%> (ø)
src/DebugLogger.js 100.00% <100.00%> (ø)
src/WinstonLogger.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(Also TIL I am a mountain climber ⛰️ )

@shazron shazron removed the request for review from sandeep-paliwal January 12, 2023 01:57
@shazron shazron marked this pull request as draft January 12, 2023 01:58
@shazron shazron marked this pull request as draft January 12, 2023 01:58
@shazron
Copy link
Member Author

shazron commented Jan 12, 2023

LGTM!

d'oh! it was a nice exercise, but I just realized I was just re-implementing node:util.format 😱 Reworking this PR

@shazron shazron marked this pull request as ready for review January 12, 2023 02:26
@shazron
Copy link
Member Author

shazron commented Jan 12, 2023

Fixed 😅 (build failures because of eslint-plugin-import 2.27.0, which is pending a patch)

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! (and learned about util.format myself 🙂 )

@shazron shazron merged commit ba74b9c into master Jan 18, 2023
@shazron shazron deleted the variadic-args branch January 18, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging should pretty print objects log stack trace if input is Error?
3 participants