-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
Serbian translation was missing translated strings for several menu options and tooltips. These are now covered, and also some previous translations for the UI were modified to be more "user friendly".
I can see that Travis build failed, so I submitted the contributor license agreement here http://dev.brackets.io/brackets-contributor-license-agreement.html |
@goranvasic You have some duplicate keys that are causing some linting errors.
|
@@ -457,3 +518,5 @@ define({ | |||
// extensions/default/WebPlatformDocs | |||
"DOCS_MORE_LINK" : "Прочитај више" | |||
}); | |||
|
|||
/* Last translated for 752856d58d2e9dde14e1af6be615bb7080727b7a */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you get this? This is not a valid SHA. You have to look up from this history page and copy the SHA from the one that you're translating for. Make sure you have the exact total line numbers in your localized file when comparing (diffing) to the English strings and also ensure that your localized file does not have keys in a different order from root/strings.js
. Once you verify the order and diffing the changes properly, then you will also fix the linting issue from Travis.
Refactored entire Serbian translation strings.js file so that it is in sync with root/strings.js - previously its structure, line numbers and order of the keys were different. Correct SHA for the last commit on root/strings.js has been added to the bottom of the file.
@RaymondLim Could you please check the Travis CI build, it seems that it was not able to properly execute npm command. Note that I submitted my commit directly from web browser. |
@goranvasic Not sure what went wrong with |
@RaymondLim Thank you. |
@RaymondLim I see that this pull request is still not merged so please let me know if there is anything else that needs to be done on my side. |
@goranvasic Do you have someone that can do the linguistic review? |
@frennky can you please review this translation? |
Everything looks good to me. |
@frennky Thanks |
Serbian translation was missing translated strings for several menu options and tooltips. These are now covered, and also some previous translations for the UI were modified to be more "user friendly".