Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump cimg/node to 14.21 #318

Merged
merged 6 commits into from
Nov 8, 2022
Merged

test: bump cimg/node to 14.21 #318

merged 6 commits into from
Nov 8, 2022

Conversation

stefan-guggisberg
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

This PR will trigger no release when merged.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #318 (73b4243) into main (9040d24) will not change coverage.
The diff coverage is n/a.

❗ Current head 73b4243 differs from pull request most recent head daff016. Consider uploading reports for the commit daff016 to get more accurate results

@@            Coverage Diff            @@
##              main      #318   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          987       987           
=========================================
  Hits           987       987           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stefan-guggisberg
Copy link
Contributor Author

stefan-guggisberg commented Nov 7, 2022

They changed not just the Nodejs version in the docker image but also the Ubuntu version (20.04.4 -> 22.04.1) and the build-essential package: https://circleci.com/developer/images/image/cimg/node

@stefan-guggisberg
Copy link
Contributor Author

It's OpenSSL v3 on Ubuntu 22.04 which breaks pem: Dexus/pem#316

Either wait for a pem update or stay on cimg:node:14.20 for now.

@stefan-guggisberg
Copy link
Contributor Author

related: coder/code-server#5162

@stefan-guggisberg stefan-guggisberg merged commit 6fe1505 into main Nov 8, 2022
@stefan-guggisberg stefan-guggisberg deleted the bump-cimg branch November 8, 2022 14:08
@github-actions
Copy link

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant