fix: ensure that AEM_NO_OPEN works as expected (#2324)

fixes #2323
adobe · Mar 7, 2024 · c985c13 · c985c13
1 parent d0f0bca
commit c985c13
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/src/cli.js b/src/cli.js
@@ -31,6 +31,11 @@ function envAwareStrict(args, aliases) {
         hlxEnv[camelcase(key.substring(4))] = key;
       }
     });
+  // setting the AEM_NO_OPEN doesn't seem to set args.open to false automatically...
+  if (args.noOpen) {
+    // eslint-disable-next-line no-param-reassign
+    args.open = false;
+  }
 
   const unknown = [];
   Object.keys(args).forEach((key) => {

diff --git a/src/up.js b/src/up.js
@@ -102,6 +102,9 @@ export default function up() {
         executor = new UpCommand(getOrCreateLogger(argv));
       }
 
+      console.log('   open', argv.open);
+      console.log('no-open', argv.noOpen);
+
       await executor
         .withHttpPort(argv.port)
         .withBindAddr(argv.addr)

diff --git a/test/fixtures/all.env b/test/fixtures/all.env
@@ -18,7 +18,7 @@ AEM_FILES=*.htl,*.js
 # up
 AEM_PRINT_INDEX=true
 AEM_HOST=www.project-helix.io
-AEM_OPEN=false
+AEM_NO_OPEN=true
 AEM_LIVERELOAD=false
 AEM_PORT=1234
 AEM_ADDR=*

diff --git a/test/import-cli.test.js b/test/import-cli.test.js
@@ -67,7 +67,7 @@ describe('hlx import', () => {
   it('hlx import can use env', async () => {
     dotenv.config({ path: path.resolve(__rootdir, 'test', 'fixtures', 'all.env') });
     await cli.run(['import']);
-    sinon.assert.calledWith(mockImport.withOpen, 'false');
+    sinon.assert.calledWith(mockImport.withOpen, false);
     sinon.assert.calledWith(mockImport.withHttpPort, 1234);
     sinon.assert.calledOnce(mockImport.run);
   });

diff --git a/test/up-cli.test.js b/test/up-cli.test.js
@@ -66,7 +66,7 @@ describe('hlx up', () => {
   it('hlx up can use env', async () => {
     dotenv.config({ path: path.resolve(__rootdir, 'test', 'fixtures', 'all.env') });
     await cli.run(['up']);
-    sinon.assert.calledWith(mockUp.withOpen, 'false');
+    sinon.assert.calledWith(mockUp.withOpen, false);
     sinon.assert.calledWith(mockUp.withLiveReload, false);
     sinon.assert.calledWith(mockUp.withHttpPort, 1234);
     sinon.assert.calledWith(mockUp.withBindAddr, '*');