Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrades to svg doctor #426

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat: upgrades to svg doctor #426

merged 2 commits into from
Dec 6, 2023

Conversation

fkakatie
Copy link
Member

Description

  • allow users to continue to drag-and-drop svgs after uploading the first (users can upload another svg without clicking the "reset" button)
  • selected buttons (eg. dark vs. light mode, button vs. image display) are marked

How Has This Been Tested?

https://svg-doctor--helix-website--adobe.hlx.live/tools/svg-doctor/

Screenshots (if appropriate):

Screen Shot 2023-11-30 at 3 52 40 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Nov 30, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/tools/svg-doctor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie
Copy link
Member Author

Screen Shot 2023-11-30 at 3 55 02 PM Screen Shot 2023-11-30 at 3 55 47 PM

@fkakatie fkakatie merged commit 90a73d2 into main Dec 6, 2023
2 of 3 checks passed
@fkakatie fkakatie deleted the svg-doctor branch December 6, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants