Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rough draft of mp4 doctor #446

Merged
merged 4 commits into from
Jan 19, 2024
Merged

feat: rough draft of mp4 doctor #446

merged 4 commits into from
Jan 19, 2024

Conversation

fkakatie
Copy link
Member

@fkakatie fkakatie commented Jan 9, 2024

Description

How Has This Been Tested?

https://mp4-doc--helix-website--adobe.hlx.page/tools/mp4-doctor/

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Jan 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 9, 2024

Page Scores Audits Google
/tools/mp4-doctor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dkuntze dkuntze marked this pull request as ready for review January 19, 2024 17:36
@dkuntze dkuntze self-assigned this Jan 19, 2024
@fkakatie fkakatie merged commit e6a6117 into main Jan 19, 2024
3 checks passed
@fkakatie fkakatie deleted the mp4-doc branch January 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants