Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minirum integration #461

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Minirum integration #461

merged 10 commits into from
Mar 11, 2024

Conversation

chicharr
Copy link
Collaborator

@chicharr chicharr commented Jan 31, 2024

Update helix website to use Minirum.

This PR has a hard dependency on Helix5 as it pulls enhancer from the project domain /.rum/@adobe/helix-rum-enhancer@^2/..

Description

Instrumentation of minirum, pulling enhancer 2.x.
Changes on experimentation plugin to use new events sent by sampleRUM replacing `sampleRUM.always.on``

Related Issue

#451

Screenshots (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Test URLS:
https://myminirum--helix-website--adobe.aem.live/home
vs.
https://main--helix-website--adobe.aem.live/home

Copy link

aem-code-sync bot commented Jan 31, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@chicharr chicharr requested a review from trieloff January 31, 2024 13:58
@chicharr chicharr changed the title Myminirum Minirum integration Jan 31, 2024
Copy link

aem-code-sync bot commented Mar 6, 2024

Page Scores Audits Google
/home PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@trieloff trieloff merged commit 373a812 into main Mar 11, 2024
4 checks passed
@trieloff trieloff deleted the myminirum branch March 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants