Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use Cruncher model #507

Merged
merged 23 commits into from
May 13, 2024
Merged

Refactor: use Cruncher model #507

merged 23 commits into from
May 13, 2024

Conversation

trieloff
Copy link
Contributor

A number of changes in this PR, attaching screenshots

Performance

New: 109 ms
Screenshot 2024-05-10 at 12 07 12

Old: 114 ms

Screenshot 2024-05-10 at 12 06 50

No significant difference

Chart

  • better interpolation of data series
  • if too few CWV data points are available, then no red, yellow, green bars will be rendered
Screenshot 2024-05-10 at 12 09 44

Old:

Screenshot 2024-05-10 at 12 08 47

Facets

New:

  • User Agent has a human readable label
  • mobile facet value now includes all mobile operating systems (same for others)
Screenshot 2024-05-10 at 12 09 44

Old:

Screenshot 2024-05-10 at 12 08 47

CWV Chiclets

  • if too few CWV data points are available, no CWV value will be shown
  • if the CWV distribution differs significantly from the baseline, a bolder border will be drawn around the data point, guiding attention to where it matters
Screenshot 2024-05-10 at 12 14 41

UTM Filtering

  • Enforce hierarchical nature of exploration, UTM Target facet is only shown when UTM source facet has a value
  • Separate different source values based on target value for UTM
Screenshot 2024-05-10 at 12 18 58

Test at https://use-model--helix-website--adobe.aem.live/tools/rum/explorer.html

  • test(rum-explorer): adds simple, dependency-free tests
  • test(rum-explorer): basic test for addCalculatedProps
  • docs(rum-explorer): typedefs for chunk, bundle, and event
  • fix(rum-explorer): fix and test bundles and filter function
  • test(rum-explorer): add test for group function
  • test(rum-explorer): add tests for totals and aggregates
  • test(rum-explorer): test facets
  • style(slicer): make eslint happy
  • docs(cruncher): document the addSeries function
  • fix(cruncher): do not consider undefined values for series aggregates
  • refactor(slicer): use dataChunks for top6 hero stats
  • refactor(rum-explorer): use new model for hero chart
  • fix(rum-explorer): generate groups for entire timeline, do not skip days of empty data
  • refactor(rum-explorer): use facet filters from model
  • fix(rum-explorer): more intelligent facets and simpler filters
  • refactor(rum-explorer): use new filters to filter dataset
  • feat(rum-explorer): decorate facet names, optionally hide facets
  • fix(rum-explorer): don't show p75 of CWV for facets if less than 10 data points available
  • feat(rum-explorer): display significance of CWV deviation
  • feat(rum-explorer): allow filtering by UTM parameter

trieloff added 21 commits May 6, 2024 17:58
realizing that facets and filters are two sides of the same coin,
this refactoring allows you to specify a filter as a simple object
that is a map of valid filter values. These values will be compared
against the facet's value function
Copy link

aem-code-sync bot commented May 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 10, 2024

Page Scores Audits Google
/tools/rum/explorer.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@trieloff trieloff requested a review from davidnuescheler May 10, 2024 10:23
@trieloff trieloff merged commit 7ad92d8 into main May 13, 2024
4 checks passed
@trieloff trieloff deleted the use-model branch May 13, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant