Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RUM): visit entry to use enterSource facet from distiller #691

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

asthabh23
Copy link
Member

Description

This PR contains updates for visit entry checkpoint to use enterSource facet from distiller instead of the default enter.source

Related Issue

#690

How Has This Been Tested?

Tested for both rum and oversight

Screenshots (if appropriate):

Earlier:
Screenshot 2024-12-05 at 18 47 00

Updated:
Screenshot 2024-12-05 at 18 47 27

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

https://main--helix-website--adobe.hlx.live/tools/oversight/explorer.html?domain=emigrationbrewing.com&filter=&view=month&=performance&checkpoint=enter&domainkey=open&conversion.checkpoint=click
vs
https://issue-690--helix-website--adobe.hlx.live/tools/oversight/explorer.html?domain=emigrationbrewing.com&filter=&view=month&=performance&checkpoint=enter&domainkey=open&conversion.checkpoint=click

Copy link

aem-code-sync bot commented Dec 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do this with more surgical changes. By re-using the enter.source facet name, we don't break the URLs.

tools/oversight/slicer.js Outdated Show resolved Hide resolved
tools/rum/explorer.html Outdated Show resolved Hide resolved
@asthabh23 asthabh23 merged commit 2f0e5cb into main Dec 6, 2024
3 of 4 checks passed
@asthabh23 asthabh23 deleted the issue-690 branch December 6, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RUM] Visit Entry Checkpoint - External referrer - switch to use enterSource facet from distiller
2 participants