Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back skipped tests #380

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Bring back skipped tests #380

merged 1 commit into from
Nov 28, 2019

Conversation

snewcomer
Copy link
Collaborator

ref #379

@sandstrom - yes but only with changeset.set('dogs', [...oldDogs, newDog])

@snewcomer snewcomer self-assigned this Nov 28, 2019
@snewcomer snewcomer merged commit 25a5212 into master Nov 28, 2019
@snewcomer snewcomer deleted the sn/add-tests branch November 28, 2019 17:28
@sandstrom
Copy link

@snewcomer Awesome news, will look into it this afternoon! 😄

@RobbieTheWagner
Copy link
Member

@snewcomer @sandstrom is this saying you cannot do addObject or pushObject and must instead create a new array and set it on the changeset? We should document hasMany and belongsTo in the README probably?

@sandstrom
Copy link

@rwwagner90 That's how I understood it yes, but I'm not 100% sure

@snewcomer
Copy link
Collaborator Author

Some doc updates would probably be a good idea! This is mainly due to our use of tracked (without track-built-ins)

@RobbieTheWagner
Copy link
Member

@snewcomer thanks for the clarification. Is this only for hasMany or is this any array? I can take a stab at writing some docs.

@snewcomer
Copy link
Collaborator Author

https://github.com/poteto/ember-changeset/blob/master/tests/integration/main-test.js#L187

Lmk if these tests are helpful at all and/or is different than what you though it should be! And docs are always definitely appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants