Add TAP pipeline #4285
Merged
Add TAP pipeline #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
karianna
requested changes
Jan 30, 2023
|
|
||
| usage () | ||
| { | ||
| echo 'Usage : aqaTAp.sh --url <link to download TAP files> --dir <dir to store TAP files>' |
There was a problem hiding this comment.
Suggested change
| echo 'Usage : aqaTAp.sh --url <link to download TAP files> --dir <dir to store TAP files>' | |
| echo 'Usage : aqaTap.sh --url <link to download TAP files> --dir <dir to store TAP files>' |
There was a problem hiding this comment.
Thanks. I will update.
| @@ -0,0 +1,183 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Has this file been shellchecked?
There was a problem hiding this comment.
Is that a requirement? If so, do we have a doc for instruction?
There was a problem hiding this comment.
I ran the script at https://www.shellcheck.net/ and updated the script if the suggestion is applicable.
llxia
force-pushed
the
test9
branch
4 times, most recently
from
69625e6 to
2181647
Compare
karianna
approved these changes
Jan 30, 2023
smlambert
reviewed
Jan 31, 2023
There was a problem hiding this comment.
Thanks Lan, I likely am missing something in the setup of the pipeline at https://ci.adoptopenjdk.net/view/Test_grinder/job/TAP_verification/ in order to test this PR. If you have a moment to take a quick look. I can not see your internal job.
Comment on lines
7
to
9
| def TARGETS = params.TARGETS.trim().split("\\s*,\\s*"); | ||
| def LABEL = (params.LABEL) ?: "" | ||
| def LABEL_ADDITION = (params.LABEL_ADDITION) ?: "" |
There was a problem hiding this comment.
Are TARGETS and LABEL_ADDITION used/needed?
There was a problem hiding this comment.
- https://ci.adoptopenjdk.net/view/Test_grinder/job/TAP_verification/11/console does not work because this PR has not been merged.
aqaTap.shdoes not exist in master. I can do a demo this afternoon. TARGETSis intended for future use. I would like users to provide what TARGET they want to check, not just be limited to the predefined AQA 9 targets.- yes,
LABEL_ADDITIONis not needed. It should be removed.
There was a problem hiding this comment.
I have pointed the main config to your branch (where aqaTap.sh exists), but realize I need to run with CUSTOMIZED_SDK_URL_CREDENTIAL_ID.
There was a problem hiding this comment.
ah, your fork is openjdk-tests, not aqa-tests, I see my testing dilemna !
resolves: adoptium#4277 Signed-off-by: Lan Xia <[email protected]>
smlambert
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #4277
Signed-off-by: Lan Xia [email protected]