Exclude EC curves fo RH ojdk 17 #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
approved these changes
Feb 27, 2023
smlambert
reviewed
Mar 1, 2023
There was a problem hiding this comment.
thanks @RadekCap - my only comment to this is that these 2 testcases are part of jdk_security3 target, so to keep things organized by target, you may want to create a section between jdk_security and jdk_security4 in this file, and move these 2 lines into that section.
smlambert
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing ECCurves on our version.
I'm not sure about proper exclusion syntax, pls feel free to point me to some source if exists. I guess it from the existing exclusions around.