Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support base docker registry login to increase pull limit #4842

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

LongyuZhang
Copy link
Contributor

@LongyuZhang LongyuZhang commented Oct 30, 2023

  • Pulling image from dockerhub reaches limit during release
  • Enabling base_docker_registry_credential to increase this limit
  • Related Issue: runtimes/backlog/issues/1234

@LongyuZhang LongyuZhang marked this pull request as draft October 30, 2023 19:03
- Pulling image from dockerhub reaches limit during release
- Enabling base_docker_registry_credential to increase this limit

Signed-off-by: LongyuZhang <[email protected]>
@LongyuZhang LongyuZhang marked this pull request as ready for review November 7, 2023 19:46
@LongyuZhang
Copy link
Contributor Author

Test Links (hyc_grinder):

  • ubi checkpoint: 35883 restore: 35887
  • ubu checkpoint: 35881 restore: 35886
  • pingperf checkpoint: 35882 restore: 35888

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LongyuZhang

@llxia
Copy link
Contributor

llxia commented Nov 9, 2023

@smlambert could you review this PR? It is currently blocking the CRIU testing. Thanks.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smlambert smlambert merged commit 4a1eca1 into adoptium:master Nov 9, 2023
2 checks passed
llxia pushed a commit to llxia/aqa-tests that referenced this pull request Nov 22, 2023
)

- Pulling image from dockerhub reaches limit during release
- Enabling base_docker_registry_credential to increase this limit

Signed-off-by: LongyuZhang <[email protected]>
pshipton pushed a commit that referenced this pull request Nov 22, 2023
- Pulling image from dockerhub reaches limit during release
- Enabling base_docker_registry_credential to increase this limit

Signed-off-by: LongyuZhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants