Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problemlist sun/jvmstat/monitor/MonitoredVm/CR6672135.java in jdk8u #5742

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

sendaoYan
Copy link
Contributor

Problemlist jtreg sun/jvmstat/monitor/MonitoredVm/CR6672135.java in jdk8u, which run intermittent fails

The intermittent failure was recorded by JDK-8062938, before the upstream test bug has been backported to jdk8u, should we Problemlist this test.

Fixes: #5741

Problemlist jtreg sun/jvmstat/monitor/MonitoredVm/CR6672135.java in jdk8u, which run intermittent fails

Fixes: adoptium#5741
Signed-off-by: sendaoYan <[email protected]>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sendaoYan - for this exclusion, instead of just an alibaba/ProblemList change, please modify https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk8.txt#L343 to indicating JDK-8062938 and generic-all

@sendaoYan
Copy link
Contributor Author

thanks @sendaoYan - for this exclusion, instead of just an alibaba/ProblemList change, please modify https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk8.txt#L343 to indicating JDK-8062938 and generic-all

Okey, the test CR6672135.java has been Problemlisted for all vendors.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sendaoYan!

(To your point of keeping both issues listed, for now, when there are 2 issues against 1 exclusion, we have been putting a comment above the exclusion line, as some of the tooling created to parse these files will need to be updated to handle comma-separated issues, i.e. https://github.com/adoptium/aqa-tests/tree/master/scripts/disabled_tests#disabled-tests----tools-and-scripts). I am also happy to drop #3691 off of the list, since it does not contain enough information to investigate anyway.

@LongyuZhang LongyuZhang merged commit 61c8207 into adoptium:master Nov 12, 2024
3 checks passed
@sendaoYan sendaoYan deleted the issue5741 branch November 12, 2024 23:52
@sendaoYan
Copy link
Contributor Author

Thanks all for the review and integrate.

@sendaoYan
Copy link
Contributor Author

That's great job that's we have created tools to statistic disable tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problemlist sun/jvmstat/monitor/MonitoredVm/CR6672135.java
3 participants