Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude jdk_bean subtest Test6397609 and Test5102804 #5803

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Dec 6, 2024

  • Exclude jdk_bean subtest -Test6397609 and Test5102804 on xlinux JDK8.

related: eclipse-openj9/openj9#20531

@annaibm
Copy link
Contributor Author

annaibm commented Dec 6, 2024

@annaibm annaibm changed the title Exclude jdk_bean subtest Test6397609,Test5102804 Exclude jdk_bean subtest Test6397609 and Test5102804 Dec 6, 2024
@llxia
Copy link
Contributor

llxia commented Dec 6, 2024

This PR and #5802 modified the same file at the same line. Depends on which one to merge first, the other one will need to be rebased.

@annaibm annaibm force-pushed the excsubtestJDK8xlinux branch from 7eafd48 to 5043c1b Compare December 6, 2024 21:58
@llxia
Copy link
Contributor

llxia commented Dec 6, 2024

re #5803 (comment), you Grinders are invalid. Please use jdk_bean, not TARGET: java/beans/Introspector/Test5102804.java

@llxia
Copy link
Contributor

llxia commented Dec 7, 2024

Please rebase this PR and update the Grinder links

@annaibm annaibm force-pushed the excsubtestJDK8xlinux branch from 5043c1b to df1c734 Compare December 9, 2024 15:32
- Exclude jdk_bean subtest -`Test6397609` and `
Test5102804` on xlinux JDK8

related: eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm force-pushed the excsubtestJDK8xlinux branch from df1c734 to 39e6bc0 Compare December 9, 2024 16:22
@annaibm
Copy link
Contributor Author

annaibm commented Dec 9, 2024

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented Dec 9, 2024

Friendly reminder: please backport this change into v1.0.5

@llxia llxia requested a review from LongyuZhang December 9, 2024 16:42
@LongyuZhang LongyuZhang merged commit fd581a3 into adoptium:master Dec 9, 2024
2 of 3 checks passed
annaibm added a commit to annaibm/aqa-tests that referenced this pull request Dec 9, 2024
- Exclude jdk_bean subtest -`Test6397609` and `
Test5102804` on xlinux JDK8

related: eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
LongyuZhang pushed a commit that referenced this pull request Dec 9, 2024
- Exclude jdk_bean subtest -`Test6397609` and `
Test5102804` on xlinux JDK8

related: eclipse-openj9/openj9#20531

Signed-off-by: Anna Babu Palathingal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants