Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all Temurin windows pipelines to use vs2022 label as that is what they are configured to run with #1151

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Nov 28, 2024

New machines, including the docker provisioned ones, will only have Visual Studio 2022 installed so do not have the earlier labels. Despite this, some of the builds are still looking for the labels relating to earlier versions of Visual Studio despite using VS2022 now. This fixes the labels so they are in sync with what the builds are really using.

@sxa sxa self-assigned this Nov 28, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

…e configured to run with

Signed-off-by: Stewart X Addison <[email protected]>
@sxa sxa force-pushed the win_vs2022_labels branch from 42234d7 to cc6b31a Compare November 28, 2024 10:46
@sxa sxa changed the title Set all windows pipelines to use vs2022 as that is what they use Set all Temurin windows pipelines to use vs2022 label as that is what they are configured to run with Nov 28, 2024
@adamfarley
Copy link
Contributor

Hey @sxa, I notice that the set of labels we use for windows 32bit builds only has one machine (disabled for now, it seems). However, if we change vs2019 to vs2022, we get no machines.

Perhaps the node could be updated, or a 32bit tag added to a different vs2022 machine?

@sxa
Copy link
Member Author

sxa commented Nov 28, 2024

or a 32bit tag added to a different vs2022 machine?

Done - good spot. There are no specific 32-bit machines in our set, so the tag is effectively irrelevant now, as all of the machines are capable of building and testing 32-bit builds.

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa sxa merged commit 782ebb0 into adoptium:master Nov 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants