Use VS 2022 by default for all JDK versions + skip freetype patching

[sxa]

Updating to use VS2022 for all Temurin builds. This change has been approved by the PMC today, but if it causes any unexpected issues it can be reverted.

freetype patching can (and should be, otherwise it tries to reference things that don't exist) be skipped when we're not building JDK8 with VS2017 otherwise it tries to reference a file that isn't where it's expecting.

I'm currently testing with this branch on a machine which only has the VS2022 build tools installed and will report back once it's complete, but it's got to the middle of the build with jdk8u so I'm confident no other issues will show up, and standalone testing before creating this PR looked good.

Alternate solutions:

• I was tempted to just comment out the individual TOOLCHAIN_VERSION overrides instead of deleting them for now so that we knew where they all were.
• We could change all of the other versions explicitly to 2022 instead of providing a default at the start but this feels a lot cleaner given that we really do have a "standard" version that we're changing to.

This should leave OpenJ9 unaffected, but I'll tag in @AdamBrousseau too (LMK if you want this to apply to OpenJ9 as well)

Closes #2922

[AdamBrousseau]

I believe Semeru has switched over to VS2022 for all jdk versions for some time now. We should do the same for the OpenJ9 builds at Adoptium.

[sxa]

I believe Semeru has switched over to VS2022 for all jdk versions for some time now. We should do the same for the OpenJ9 builds at Adoptium.

Thanks - PR updated. That makes it simpler :-)

Note for reviewers: We can probably optimise this file a bit more sine we have fewer conditions which are different across versions.

[sxa]

PR has failed the JDK8 check but it's attempting to build with compiler version 19.40.33807 instead of the 19.37.32822 which we use which I believe is the cause of the check failure and would impact running on our machines.

Noting that I'm not sure where the VS2022 comes from the github checks. https://github.com/adoptium/temurin-build/blob/master/.github/workflows/build.yml has an explicit reference to the URLs for earlier compiler versions but not 2022.

[sxa]

Removing jdk8u/windows test for now (Ideally I'd make it conditionally set CONFIGURE_ARGS=--with-toolchain=2019 to let it build on an older version for now, but I haven't got the syntax worked out yet)

[gdams]

LGTM (although as discussed in Slack, I'd like to switch over to using the docker image as a base once we've got one published)

[sxa]

jdk8u test removed for now as the default win2022 image in GitHub Actions has a pre-installed VS2022 compiler which is newer than the one we want and fails to compiler jdk8u.

[AdamBrousseau]

Let us know when you have a Windows build docker image. I'd be interested in using it too.

[sxa]

Let us know when you have a Windows build docker image. I'd be interested in using it too.

@AdamBrousseau There is a functional dockerfile for this in https://github.com/adoptium/infrastructure/pull/3702/files :-)

[steelhead31]

Looks good!

[karianna]

@sxa safe to merge?

[sxa]

@sxa safe to merge?

Yep I think so now - was leaving it a bit to ensure that anyone who wanted to comment could do so.