Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: enable --create-sbom (in temurin-build) by passing new flag #308

Merged
merged 1 commit into from
May 24, 2022

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented May 20, 2022

- windows is working with --create-sbom
- enable --create-sbom flag for all jdk version * platform
- by default, value set in temurin-build

merge this PR after temurin-build PR is merged

This reverts commit 03de63a.

Ref: adoptium/temurin-build#2900

…flag into BUILD_ARGS (adoptium#297)"

	- enable --create-sbom flag for all jdk version * platform
	- by default, value set in temurin-build

This reverts commit 03de63a.
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zdtsw
Copy link
Contributor Author

zdtsw commented May 24, 2022

@smlambert can you review this one too?

@smlambert smlambert merged commit 5ef0745 into adoptium:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants