Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use (local) rhel7_build_image for Linux/s390x builds #642

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Use (local) rhel7_build_image for Linux/s390x builds #642

merged 1 commit into from
Mar 8, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Mar 7, 2023

Needs #611 merged first
Fixes adoptium/infrastructure#2731

@sxa sxa self-assigned this Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@github-actions github-actions bot added jenkins-pipeline s390x Issues that affect or relate to the s390x LINUX OS labels Mar 7, 2023
@sxa
Copy link
Member Author

sxa commented Mar 7, 2023

run tests

@sxa sxa requested a review from andrew-m-leonard March 7, 2023 12:34
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@karianna karianna marked this pull request as draft March 7, 2023 21:03
@karianna
Copy link
Contributor

karianna commented Mar 7, 2023

making draft to make sure I don't land before the precuror has landed.

steelhead31
steelhead31 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrew-m-leonard
andrew-m-leonard approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sxa sxa marked this pull request as ready for review March 8, 2023 15:13
@sxa sxa merged commit b7a1cbc into adoptium:master Mar 8, 2023
sxa added a commit to sxa/ci-jenkins-pipelines that referenced this pull request Mar 9, 2023
@sxa
Use rhel7_build_image for Linux/s390x builds (adoptium#642)
470a500 
Signed-off-by: Stewart X Addison <[email protected]>
steelhead31 pushed a commit that referenced this pull request Mar 9, 2023
@sxa
Use rhel7_build_image for Linux/s390x builds (#642) (#652)
2ca3580 
Signed-off-by: Stewart X Addison <[email protected]>
@sxa sxa mentioned this pull request Apr 11, 2023
Closed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
@sxa @luhenry
Use rhel7_build_image for Linux/s390x builds (adoptium#642)
8e21694 
Signed-off-by: Stewart X Addison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@karianna karianna karianna approved these changes

Assignees

@sxa sxa

Labels
jenkins-pipeline s390x Issues that affect or relate to the s390x LINUX OS
Projects
No open projects
Adoptium 1Q 2023 Plan
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support and use docker builds on Linux/s390x
5 participants
@sxa @eclipse-temurin-bot @karianna @andrew-m-leonard @steelhead31