Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Add fontconfig to DockerStatic Dockerfiles #2130

Merged
merged 1 commit into from
May 13, 2021

Conversation

sxa
Copy link
Member

@sxa sxa commented Apr 14, 2021

Fixes adoptium/aqa-tests#2357 (Once deployed to all existing systems)

Signed-off-by: Stewart X Addison [email protected]

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@sxa sxa added this to the April 2021 milestone Apr 14, 2021
@sxa sxa self-assigned this Apr 14, 2021
@github-actions github-actions bot added ansible and removed docker labels Apr 14, 2021
@sxa
Copy link
Member Author

sxa commented Apr 14, 2021

This has been deployed on the test-docker machines other than test-docker-fedora33-armv8-1 which seems to have a broken package manager so I've just disabled it (It's on a host which is due to be decomissioned soon anyway)

for CONTAINER in `docker ps | awk '{print$NF}' | grep ^f33`; do docker exec $CONTAINER dnf -y install fontconfig; done
for CONTAINER in `docker ps | awk '{print$NF}' | grep ^U`; do docker exec $CONTAINER apt-get -y install fontconfig; done

@sxa
Copy link
Member Author

sxa commented Apr 14, 2021

Apparently the check failure on macos is a known issue with gdams has raised with GitHub

@sxa sxa force-pushed the dockerstatic_fontconfig branch from 298b5c9 to b87aeb9 Compare April 15, 2021 17:53
Copy link

@lumpfish lumpfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert
Copy link
Contributor

smlambert commented May 13, 2021

I suggest the remainder of that checklist be done in a follow-up PR so that we can resolve the many test failures on the merge of the changes currently in this PR.

EDIT: I see the comment in the Slack channel saying this part is already deployed on the machines, thanks!

@sxa
Copy link
Member Author

sxa commented May 13, 2021

I suggest the remainder of that checklist be done in a follow-up PR so that we can resolve the many test failures on the merge of the changes currently in this PR.

@smlambert If by checklist you mean the checkboxes in the description they are not appropriate for this PR. However based on the comment above at #2130 (comment) it should already have been deployed to most of the machines so if there's something not working let me know (in which case I want to check there's not an additional requirement before merging this!)

@sxa
Copy link
Member Author

sxa commented May 13, 2021

Was missing from a couple of the images on that host - fixed and will merge (Docker/Alpine issue seems to be a docker problem unrelated to this)

@sxa sxa merged commit e881eaf into adoptium:master May 13, 2021
@karianna karianna modified the milestones: April 2021, May 2021 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extended.openjdk failure: javax/imageio/AppletResourceTest.java : FontConfiguration NPE
4 participants