-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: Add fontconfig to DockerStatic Dockerfiles #2130
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
This has been deployed on the
|
Apparently the check failure on macos is a known issue with gdams has raised with GitHub |
298b5c9
to
b87aeb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I suggest the remainder of that checklist be done in a follow-up PR so that we can resolve the many test failures on the merge of the changes currently in this PR. EDIT: I see the comment in the Slack channel saying this part is already deployed on the machines, thanks! |
@smlambert If by checklist you mean the checkboxes in the description they are not appropriate for this PR. However based on the comment above at #2130 (comment) it should already have been deployed to most of the machines so if there's something not working let me know (in which case I want to check there's not an additional requirement before merging this!) |
Was missing from a couple of the images on that host - fixed and will merge (Docker/Alpine issue seems to be a docker problem unrelated to this) |
Fixes adoptium/aqa-tests#2357 (Once deployed to all existing systems)
Signed-off-by: Stewart X Addison [email protected]
Checklist