Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added storage monitoring Jenkins job #13

Merged
merged 5 commits into from
Mar 29, 2018
Merged

Conversation

VermaSh
Copy link
Contributor

@VermaSh VermaSh commented Mar 26, 2018

This addresses Storage Monitoring Jenkins job

  • Implemented storage monitoring job for linux, aix, and mac
  • Updated the readme to reflect the new Jenkins job

VermaSh added 2 commits March 26, 2018 10:25
Implemented storage monitoring job for linux, aix, and mac
Updated the readme to reflect the new Jenkins job
output += "\n=======================================================================\n\n";
}

parallel clones
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline at the end of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

stage('Print_Space_Monitoring_Data') {
NodeHelper nodeHelper = new NodeHelper();

String projectLabel = params.projectLabel;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't define this parameter, or if I don't set it, will I iterate over all the nodes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't iterate over any nodes. That's on my todo for after I have checked in rest of the jobs

@karianna karianna added the enhancement New feature or request label Mar 27, 2018
- Added new line at the end of file
- Fixed formatting in README
@gdams
Copy link
Member

gdams commented Mar 29, 2018

@AdamBrousseau are you happy with the PR now?

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving extra change 01459bd

@VermaSh VermaSh merged commit 6e8c8f2 into adoptium:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants