-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added storage monitoring Jenkins job #13
Conversation
Implemented storage monitoring job for linux, aix, and mac Updated the readme to reflect the new Jenkins job
Jenkins_jobs/WorkspaceInfo.groovy
Outdated
output += "\n=======================================================================\n\n"; | ||
} | ||
|
||
parallel clones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a newline at the end of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Jenkins_jobs/WorkspaceInfo.groovy
Outdated
stage('Print_Space_Monitoring_Data') { | ||
NodeHelper nodeHelper = new NodeHelper(); | ||
|
||
String projectLabel = params.projectLabel; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I don't define this parameter, or if I don't set it, will I iterate over all the nodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't iterate over any nodes. That's on my todo for after I have checked in rest of the jobs
- Added new line at the end of file - Fixed formatting in README
@AdamBrousseau are you happy with the PR now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving extra change 01459bd
This addresses Storage Monitoring Jenkins job