Add classes.jar for sharedClassesTestData into specific jdk version dir. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LongyuZhang
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Some other comments:
- Line 2 Copyright needs to be updated to 2016, 2024.
Also, the class files need to be changed to store in WorkSpace folder based on SharedClasses.SCM01.SingleCL UnsupportedClassVersionError eclipse-openj9/openj9#19582 (comment)(This will be done in other pre-stage PRs)
openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/stf/SharedClasses.java
Show resolved
Hide resolved
- Add the classes jars for SharedClassesTest data into specific jdk version dir. - Updated copyright to 2016, 2024. related:eclipse-openj9/openj9#19582 Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm
force-pushed
the
system_test_jdkdir
branch
from
dfc29ca
to
f685fc1
Compare
LongyuZhang
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
LGTM.
This PR is to solve the classes.jar mismatch with jdk versions problem after pre-stage libs, through storing the classes.jar under each version's own folder, e.g. sharedClassesTestData/v1/jdk17/classes.jar.
It can be merged alone since current process will delete the whole folder and rebuild each time.
pshipton
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related:eclipse-openj9/openj9#19582
Signed-off-by: Anna Babu Palathingal [email protected]