Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shorter path for cacheDir since on Windows MAX_PATH is 260 #80

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Use shorter path for cacheDir since on Windows MAX_PATH is 260 #80

merged 1 commit into from
Jan 28, 2019

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jan 28, 2019 •
edited
Loading

Related: #75 (comment):

"The length of path
"C:\Users\jenkins\workspace\Test-extended.system-JDK8-win_x86-64_cmprssptrs\openjdk-tests\TestConfig\test_output_15477678633841\SharedClassesAPI_0\20190117-174310-SharedClassesAPI\results\caches\javasharedresources\C290M4F1A64_DefinedLocationGroupAccessJavaWL4_G35"
is 262, which is greater than MAX_PATH(=260) on Windows. The cacheDir/cacheName is too long. The test needs to be updated to use a shorter cacheDir/cacheName."

@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jan 28, 2019 •
edited
Loading

What's done in this PR:

In order to keep length of cache dir within 260 chars,

  1. Cache Dir can simply be the test directory (changed);
  1. Name of cache is defined using Test names that are defined in the enum Tests. We can make these names a bit shorter, without compromising on readability.(done).

@Mesbah-Alam
Copy link
Contributor Author

@hangshao0 - FYI.

@Mesbah-Alam
Copy link
Contributor Author

@smlambert - could you please review and merge this PR?

@Mesbah-Alam
Copy link
Contributor Author

Tested on Windows using internal Jenkins (link shared on Slack).

@Mesbah-Alam
Copy link
Contributor Author

Teated on Linux here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/926/console

@smlambert smlambert merged commit ba8f6d8 into adoptium:master Jan 28, 2019
@Mesbah-Alam Mesbah-Alam mentioned this pull request Jan 28, 2019
Open
@hangshao0 hangshao0 mentioned this pull request Jan 29, 2019
Closed
@hangshao0 hangshao0 mentioned this pull request Feb 6, 2019
Closed
@Mesbah-Alam Mesbah-Alam deleted the useShorterPathForNonDefaultCacheLocation branch March 6, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mesbah-Alam @smlambert