Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: env WORKSPACE is not set for non-Jenkins env. #2921

Merged
merged 2 commits into from
May 13, 2022

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented May 12, 2022

when enable --create-sbom flag in build.sh script, it exposed an error:
https://github.com/adoptium/temurin-build/runs/6404611567?check_suite_focus=true

@zdtsw zdtsw changed the title fix: evn WORKSPACE is not set for non-Jenkins env. fix: env WORKSPACE is not set for non-Jenkins env. May 12, 2022
@zdtsw
Copy link
Contributor Author

zdtsw commented May 12, 2022

running tests t when enabled "--create-sbom" in https://github.com/adoptium/temurin-build/pull/2920/checks

@zdtsw
Copy link
Contributor Author

zdtsw commented May 13, 2022

@andrew-m-leonard can I get review on this one.
test is done in #2920 when enable the flag.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 547060c into adoptium:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants