Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable --create-sbom to set in ci-jenkins-pipeline instead default #2929

Closed
wants to merge 1 commit into from
Closed

feat: enable --create-sbom to set in ci-jenkins-pipeline instead default #2929

wants to merge 1 commit into from

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented May 16, 2022

Ref: #2900

@zdtsw zdtsw mentioned this pull request May 16, 2022
Closed
karianna
karianna approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo
Copy link
Contributor

sophia-guo commented May 16, 2022 •
edited
Loading

This should be created as the revert of https://github.com/adoptium/temurin-build/pull/2926/files?

@zdtsw
Copy link
Contributor Author

zdtsw commented May 16, 2022

This should be created as the revert of https://github.com/adoptium/temurin-build/pull/2926/files?

Yes, it is to revert back to the old logic -- default to "false"

@sophia-guo
Copy link
Contributor

Screen Shot 2022-05-16 at 1 23 00 PM

Using the revert button is probably an easier and correct way.

@zdtsw
Copy link
Contributor Author

zdtsw commented May 17, 2022

Screen Shot 2022-05-16 at 1 23 00 PM

Using the revert button is probably an easier and correct way.

made a new PR, revert old one and have this one closed

@zdtsw zdtsw closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdtsw @sophia-guo @karianna