Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Resilience Of Signing Checks For MacOS #3431

Merged
merged 33 commits into from
Jul 12, 2023
Merged

Improve Resilience Of Signing Checks For MacOS #3431

merged 33 commits into from
Jul 12, 2023

Conversation

steelhead31
Copy link
Contributor

Fixes #3428 

Include a 20 retry for each library, when it fails to sign at the first attempt.

@github-actions github-actions bot added the installer Issues that relate to our installer jobs or installer repo label Jul 12, 2023
@steelhead31
Copy link
Contributor Author

Test of the code signing resilience checks can be seen here..
https://ci.adoptium.net/job/build-scripts/job/release/job/sign_build/25715/console

adamfarley
adamfarley requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@adamfarley adamfarley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Your changes appear to cancel themselves out by failing if we needed to retry. Thoughts please.

sign.sh Outdated Show resolved Hide resolved
@steelhead31 steelhead31 requested a review from adamfarley July 12, 2023 15:32
adamfarley
adamfarley approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

andrew-m-leonard
andrew-m-leonard approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steelhead31 steelhead31 merged commit 4ac0543 into adoptium:master Jul 12, 2023
@steelhead31 steelhead31 deleted the fix_issue_3428 branch July 12, 2023 18:33
@steelhead31 steelhead31 mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@adamfarley adamfarley adamfarley approved these changes

Assignees
No one assigned
Labels
installer Issues that relate to our installer jobs or installer repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS Signing - Improve Resiliency In sign.sh script
3 participants
@steelhead31 @adamfarley @andrew-m-leonard