Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link of ADR log/toc generated will be wrong if input path and directory of the logs are different #28

Closed
Fetz opened this issue Nov 14, 2019 · 0 comments
Closed

link of ADR log/toc generated will be wrong if input path and directory of the logs are different #28

Fetz opened this issue Nov 14, 2019 · 0 comments

Comments

@Fetz
Copy link

Fetz commented Nov 14, 2019

TOC links generated by Adr-log should take in consideration the path of the input and the directory of the adr-logs

Scenario

  • with a following tree
.
├── docs
│   ├── README.md
│   ├── adr
│   │   ├── 0001-adr.md
│   │   ├── 0002-adr.md
│   │   ├── 0003-adr.md
  • with the <!-- adrlog --><!-- adrlogstop --> on the docs/README.md
  • if I execute this command
adr-log docs/README.md -d docs/adr/ -i

Expected Result:

- [ADR-0001](adr/0001-adr.md) - adr
- [ADR-0002](adr/0002-adr.md) - adr
- [ADR-0003](adr/0003-adr.md) - adr

Actual result:

- [ADR-0001](0001-adr.md) - adr
- [ADR-0002](0002-adr.md) - adr
- [ADR-0003](0003-adr.md) - adr
Fetz added a commit to Fetz/adr-log that referenced this issue Nov 15, 2019
@Fetz
fix adr#28
3b908f5
@Fetz Fetz mentioned this issue Nov 15, 2019
Merged
@koppor koppor closed this as completed in 0e2d18d Nov 15, 2019
koppor added a commit that referenced this issue Nov 15, 2019
@koppor
Merge pull request #29 from Fetz/master
0f9605a 
fix #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fetz