Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .gitignore to ignore .env file #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rcraig14
Copy link

In the Quick Start guide one of the first steps is to make a new file called .env. The gitignore does not ignore this file. This can cause credentials to be leaked if accidentally pushed up

Copy link

vercel bot commented Sep 19, 2024

Someone is attempting to deploy a commit to the JS Mastery Pro Team on Vercel.

A member of the Team first needs to authorize it.

@spencerhunter
Copy link

@adrianhajdin , 👋 This peaked our interest @Dwolla. We noticed that people are leaking their Dwolla API credentials in a .env file that are getting pushed to public repositories. We're wondering if you could remove these API credentials as well as merge this PR to add .env* to .gitignore of this project? 🙏 Feel free to tag me if you have any questions on the Dwolla side!

@FaVstarr
Copy link

FaVstarr commented Oct 4, 2024

@adrianhajdin , 👋 This peaked our interest @Dwolla. We noticed that people are leaking their Dwolla API credentials in a .env file that are getting pushed to public repositories. We're wondering if you could remove these API credentials as well as merge this PR to add .env* to .gitignore of this project? 🙏 Feel free to tag me if you have any questions on the Dwolla side!

I noticed this earlier this week, that the .env wasn't added to the gitignore, luckily for me my repo isn't public, I later unlisted my .env from git them made all the necessary changes. Thanks for raising the concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants