Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token invalidation, custom error handling, and abstraction of business logic and UI #18

Merged
merged 12 commits into from
Aug 21, 2021
Merged

Token invalidation, custom error handling, and abstraction of business logic and UI #18

merged 12 commits into from
Aug 21, 2021

Conversation

adrianmg
Copy link
Owner

This initial PR turned to be in a pretty big ass change:

  • Revoking tokens will re-trigger auth flow on clients
  • Custom error handling and a more robust api call flow
  • Complete overhaul of the business logic in /src/github.js. Thanks @sergiou87 for all the help on this one

@adrianmg adrianmg merged commit 319fdca into main Aug 21, 2021
sergiou87
sergiou87 reviewed Aug 21, 2021
View reviewed changes
index.js Show resolved Hide resolved
sergiou87
sergiou87 reviewed Aug 21, 2021
View reviewed changes
index.js Show resolved Hide resolved
sergiou87
sergiou87 reviewed Aug 21, 2021
View reviewed changes
src/ui.js Show resolved Hide resolved
sergiou87
sergiou87 reviewed Aug 21, 2021
View reviewed changes
src/ui.js Show resolved Hide resolved
sergiou87
sergiou87 reviewed Aug 21, 2021
View reviewed changes
src/ui.js Show resolved Hide resolved
@adrianmg adrianmg deleted the token-validation branch August 22, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiou87 sergiou87 sergiou87 left review comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianmg @sergiou87