Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippings tree list has unwanted borders on tree items when forced color mode in Firefox is enabled #318

Closed
aecreations opened this issue Jan 12, 2021 · 4 comments
Assignees
Milestone

Comments

@aecreations
Copy link
Owner

Clippings 6.2.4

Steps to repro:

  1. Open Firefox options
  2. Under General -> Language and Appearance -> Fonts and Colors, click Colors
  3. In the dialog that appears, change the drop-down menu selection for "Override the colors specified by the page with your selections above" to "Always", then click OK
  4. Open Clippings Manager and observe the tree list; OR, invoke Clippings -> New, and observe the tree list in the folder picker

Actual result:
The tree items have an extra, unnecessary black border; see screen shot. This issue is reproducible on any OS.

image

@aecreations aecreations added this to the 6.2.5 Redondo milestone Jan 12, 2021
@aecreations aecreations self-assigned this Jan 12, 2021
@aecreations
Copy link
Owner Author

The autocomplete rich list box in the search by name dialog needs to be fixed as well:

image

@aecreations
Copy link
Owner Author

aecreations commented Jan 16, 2021

Checkboxes also need to be fixed; when color overrides are turned on, there is no way to tell if a checkbox is ticked or not:

image

aecreations added a commit that referenced this issue Jan 16, 2021
…color overrides in Firefox is enabled

(issue #318)
@aecreations
Copy link
Owner Author

To fix the checkboxes, the SVG source for the checkbox image will need to be saved from the data: URIs as separate files for each checkbox state (active and hover), and the background colors will need to be specified in the images, rather than styling the background color from the CSS selectors for the checkbox UI elements.

@aecreations
Copy link
Owner Author

aecreations commented Jan 21, 2021

Resolving the issue with checkboxes when forced color mode is enabled is going to be a bigger fix -- in addition to the checkbox states (normal, hover and active), the user's preferred color scheme (normal vs. dark mode) also needs to be considered.

This will be handled in a separate issue - see #321.

@aecreations aecreations changed the title Clippings tree list has unwanted borders on tree items when color overrides in Firefox is enabled Clippings tree list has unwanted borders on tree items when forced color mode in Firefox is enabled Jan 21, 2021
aecreations added a commit that referenced this issue Jan 22, 2021
(part of issue #318)
- Tested on Windows 10 and macOS Catalina
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant