Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Clippings to Manifest v3 #388

Closed
aecreations opened this issue Jun 17, 2022 · 7 comments
Closed

Migrate Clippings to Manifest v3 #388

aecreations opened this issue Jun 17, 2022 · 7 comments

Comments

@aecreations
Copy link
Owner

Firefox will be implementing Manifest v3. Unlike Google Chrome, it will support Event Pages which is similar to background pages, except that it won't be persistent - it may terminate after a period of time.

Clippings needs to be modified so that it can handle unplanned termination of the background script. This will involve a massive overhaul of the Dexie-based Clippings backend architecture, as extension pages hold references to the background script (via browser.extension.getBackgroundPage(); this should be changed to use WebExtension messaging.

More info on Firefox Manifest v3:

@aecreations aecreations added this to the 7.0 San Francisco milestone Jun 17, 2022
@aecreations aecreations self-assigned this Jun 17, 2022
@aecreations
Copy link
Owner Author

Seems like there will be a grace period before Manifest v2 is deprecated. From the Mozilla Add-ons Community Blog:

MV2 will continue to work. We have not made decisions about MV2 deprecation yet. We want to see what the response and adoption of MV3 is from the community next year and will then make decisions about the future based on that.

https://blog.mozilla.org/addons/2022/10/31/begin-your-mv3-migration-by-implementing-new-features-today/comment-page-1/#comment-227534

@aecreations
Copy link
Owner Author

The browser_style key in the extension manifest is deprecated in MV3, starting in Firefox 115:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles#manifest_v3_migration

aecreations added a commit that referenced this issue May 18, 2024
- Initial implementation
- Extension fully functional until background script is terminated
aecreations added a commit that referenced this issue May 19, 2024
aecreations added a commit that referenced this issue May 19, 2024
aecreations added a commit that referenced this issue May 19, 2024
@aecreations
Copy link
Owner Author

Auto-incrementing placeholders are incorrectly reset when the background script terminates. This is because the aeClippingSubst library doesn't save the state of those placeholders into extension storage.

@aecreations
Copy link
Owner Author

The Clippings menu items for clippings and folders are duplicated every time the background script is restarted.

aecreations added a commit that referenced this issue May 20, 2024
every time the background script is restarted (part of issue #388)
aecreations added a commit that referenced this issue May 20, 2024
@aecreations
Copy link
Owner Author

Fixed a regression bug: issue #455

@aecreations
Copy link
Owner Author

Need to verify that backup notifications will still appear, especially the first-time backup notification.

@aecreations
Copy link
Owner Author

Verified backup reminder notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant