Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clipboardRead permission #95

Merged
merged 2 commits into from
Sep 17, 2017

Conversation

bunnybooboo
Copy link
Contributor

From MDN
"You can use the "cut" and "copy" commands without any special permission..."
but
"To use the "paste" command, you must have the "clipboardRead" permission"

Adding this allows pasting from the contextual menu.

@bunnybooboo
Copy link
Contributor Author

bunnybooboo commented Sep 17, 2017

Editing WebExtension manifest.json commands suggested_key via clash with Firefox reserved downloads keyboard shortcut: Ctrl + Shift + Y

Previous Firefox add-on had Ctrl + Alt + V, which is not permissible in a WebExtension. The secondary modifier "must be 'Shift'". Alt + Shift + V is reserved inside Gnome (I'm testing in Arch Linux and it seems to perform same action as Alt + V but also supposedly reserved in Orca screen reader.)

Suggested fix Alt + Shift + Y

@bunnybooboo
Copy link
Contributor Author

bunnybooboo commented Sep 17, 2017

This then provides the popup clippingKey.html which needs further work. Today I right clicked the popup to propagate with its guiding text, however the key action via the paste-shortcut-key does not work as expected. EDIT: and the paste now works as expected.

@aecreations
Copy link
Owner

Thanks for submitting this! Yeah, I did add the clipboardRead permission when I tried to implement New From Clipboard, but that didn't work on Firefox. As mentioned, there were no issues on Google Chrome. Thanks for catching the potential conflict with CTRL+SHIFT+Y.

@aecreations aecreations merged commit 9ddd38e into aecreations:BRANCH_6-0-WX Sep 17, 2017
@bunnybooboo bunnybooboo deleted the BRANCH_6-0-WX branch September 18, 2017 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants