Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all special characters are being handled properly #3

Open
aecreations opened this issue Jun 9, 2014 · 4 comments
Open

Not all special characters are being handled properly #3

aecreations opened this issue Jun 9, 2014 · 4 comments
Assignees
Labels
Milestone

Comments

@aecreations
Copy link
Owner

Not all special characters are being properly handled by the double encoding that was implemented in version 1.5.1.

The one example so far is the single quote ("’" - note that this the curly quote, NOT the straight quote), such as the web page title in the following URL:
http://www.salon.com/2014/06/09/cbs_news_huge_fatal_disaster_why_heads_need_to_roll_at_the_highest_levels/

@aecreations aecreations self-assigned this Jun 9, 2014
aecreations pushed a commit that referenced this issue Jul 6, 2014
) - moved encoding of the single and double quotes out of inner function getEncodedStr()
@aecreations aecreations added bug and removed fixed labels Jul 6, 2014
@aecreations aecreations added this to the 1.6 milestone Jul 6, 2014
@aecreations
Copy link
Owner Author

Also need to fix for the elipses character "…"

Example: http://water.epa.gov/action/advisories/acanthamoeba/index.cfm

@aecreations
Copy link
Owner Author

I thought I had fixed the right-pointing angle quote "»", but this character still isn't being encoded properly. Example (page title): http://www.urbanvillagemovement.com/

After some investigation, I found that the double angle brackets that I'm using to replace it is causing the problem:

var s = decodeURIComponent("The Urban Village Movement %3E%3E Creating Community");
print(s);
The Urban Village Movement >> Creating Community

aecreations pushed a commit that referenced this issue Jul 21, 2014
…ckporting a fix for single and double quote characters from master branch
@aecreations
Copy link
Owner Author

Need to handle the registered trademark ("®") symbol. Might also need to fix the trademark symbol ("™") as well.

Example: https://software.intel.com/en-us/realsense

@aecreations
Copy link
Owner Author

The degree sign ("°", 0x00B0) isn't being handled properly, either. It ends up as being saved as "%C2%B0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant