Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Current Tab" button disabled, and incorrect context menu item appears, when navigating reading list link in a new browser window #90

Open
aecreations opened this issue Dec 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working fixed

Comments

@aecreations
Copy link
Owner

Read Next 1.1.7

Steps to repro:

  1. Add a link to the reading list sidebar
  2. With the sidebar still open, navigate to another page or website that isn't already linked in the reading list; don't add it to the reading list
  3. Right-click on the link that was added in step 1, and choose the option to open the link in a new window

Results:

  1. The "Add Current Tab" button is disabled.
  2. In the context menu (either in the browser tab or in the page), the menu item for deleting the link appears, even though the current page isn't in the reading list.

The address bar button is unaffected.

Workaround:
Switch to another browser tab, then switch back to update the toolbar button and the context menu items.

@aecreations aecreations added the bug Something isn't working label Dec 16, 2024
@aecreations aecreations self-assigned this Dec 16, 2024
@aecreations aecreations added this to the 1.1.8 Puʻu Kukui milestone Dec 16, 2024
@aecreations
Copy link
Owner Author

The same issue occurs when right-clicking on a link in the web page and opening it in a new browser tab, and that link was already saved to the reading list.

@aecreations
Copy link
Owner Author

Adding to reading list is also affected. If I add a web page in browser window A to the reading list, the "Add Current Tab" button in the sidebar is incorrectly disabled in browser window B that is displaying a web page that isn't in the reading list.

There is similar disabling logic on the "Add Current Tab" button when removing a reading list item.

aecreations added a commit that referenced this issue Dec 25, 2024
…u item appears, when navigating reading list link in a new browser window

(issue #90)
aecreations added a commit that referenced this issue Dec 25, 2024
…u item appears, when navigating reading list link in a new browser window

(issue #90)
- Additional fixes for adding and remove reading list links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

1 participant