UVW support #15
Merged
UVW support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelanman
force-pushed
the
use_skbuild_core
branch
from
c6b6400 to
5c53bf2
Compare
* add GH actions to run linting and unit tests * big changes to meet ruff formatting standards * blacken * fix numpy reqs for py39 * rearrange into src/package directory structure * fix warnings in tests * explicitly set up fortran in GH actions --------- Co-authored-by: aelanman <[email protected]>
* add control over debugging output flags * testing uvw coordinates against astropy * uvw access in imfile reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an interface to the computed UVW coordinates, and tests the CALC uvw coordinates against a similar calculation in astropy.
This also adds a way to set various debugging flags in CALC, which will cause certain modules to print debug information. This isn't very user-friendly, but can be useful in development. As a future task, we should think about ways to clean up debug information on the fortran side and support multiple levels of verbosity.
While working on this, I found that the atmosphere module is still used for some things even if the Add-dry / Add-wet options are disabled. Certain uvw calculation modes include troposphere refraction. This should be documented further. There are special flags to control which modules get used, which may be useful for better controlling these things.