Skip to content

Commit

Permalink
[web] Do not check types from packages
Browse files Browse the repository at this point in the history
At this moment we are not using types definitions from other packages but
getting errors from @patternfly/react-core

```
> check-types
> tsc

Error: node_modules/@patternfly/react-core/dist/esm/components/Drawer/DrawerPanelContent.d.ts(3,18): error TS2430: Interface 'DrawerPanelContentProps' incorrectly extends interface 'HTMLProps<HTMLDivElement>'.
  Types of property 'onResize' are incompatible.
    Type '(width: number, id: string) => void' is not assignable to type 'ReactEventHandler<HTMLDivElement>'.

...
Error: node_modules/@patternfly/react-core/dist/esm/components/NotificationDrawer/NotificationDrawerListItemHeader.d.ts(8,35): error TS2304: Cannot find name 'SVGIconProps'.
```

See https://www.typescriptlang.org/tsconfig#skipLibCheck
  • Loading branch information
dgdavid committed Mar 2, 2023
1 parent 859736b commit 30e4509
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"eslint:fix": "eslint --fix --ext .js --ext .jsx src/",
"stylelint": "stylelint 'src/**/*.{css,scss}'",
"stylelint:fix": "stylelint --fix 'src/**/*.{css,scss}'",
"check-types": "tsc",
"check-types": "tsc --skipLibCheck",
"jsdoc": "npx typedoc src src/client && echo Tip: && echo xdg-open jsdoc.out/index.html",
"test": "jest"
},
Expand Down

0 comments on commit 30e4509

Please sign in to comment.