-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Five lemma #1166
base: master
Are you sure you want to change the base?
Five lemma #1166
Conversation
I have suggestions for improvement: |
ohhhh i see... that's a good idea. i think that would generalize the infinite ones, but for |
Ran into a problem... I was going to try unifying the new definition with For now, I implemented this with uniform level. I'm not going to touch the existing theorems yet, maybe possibly in a future revision. Also, one other question I have is that I'm using this definition now:
Based on my current understanding of exactness from literature, it seems that these should be an equivalence at the very least. But the existing lemma for Exact4 is just using invertible functions. Will the extra data pose any problems? |
Didn't mean to sit on this for so long, I am still playing around with trying to fit a generalization of exact sequences into the existing definitions, so I decided to separate that from this patch. |
I tried to define a more general notion of exact sequences for groups (as well as Fin-indexed, N-indexed, and Z-indexed), as well as use the definition to prove the five lemma.
I'm still very new to this, so I anticipate this might not be the best way to define them. Let me know if there are problems with the design of the data structures.