Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Remove old/deprecated linters #268

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Update and Remove old/deprecated linters #268

merged 1 commit into from
Jul 18, 2022

Conversation

Jacoby6000
Copy link
Contributor

@Jacoby6000 Jacoby6000 commented Mar 7, 2022

Prior to this commit, running the linters resulted in:

WARN [runner] 
The linter 'golint' is deprecated (since v1.41.0) due to: 
The repository of the linter has been archived by the owner.  
Replaced by revive.

WARN [runner]
The linter 'interfacer' is deprecated (since v1.38.0) due to:
The repository of the linter has been archived by the owner.  


WARN [runner] 
The linter 'maligned' is deprecated (since v1.38.0) due to:
The repository of the linter has been archived by the owner.  
Replaced by govet 'fieldalignment'. 

WARN [runner] 
The linter 'scopelint' is deprecated (since v1.39.0) due to:
The repository of the linter has been deprecated by the owner. 
Replaced by exportloopref. 

To remedy this I have:

@Jacoby6000 Jacoby6000 requested a review from johnboyes as a code owner March 7, 2022 17:23
@johnboyes johnboyes added the patch Semantic versioning: backwards compatible bug fixes label Jul 18, 2022
@johnboyes
Copy link
Contributor

Sincere apologies for taking so long to review and merge this, @Jacoby6000. Last few months saw me leave the UK, cycle across Europe, while continuing to work, and move to a new country - so it was an unusually hectic time to say the least! I'll be looking at your other outstanding PR in the next week as well 👍🏻

@johnboyes johnboyes merged commit ac839cc into agilepathway:master Jul 18, 2022
@johnboyes
Copy link
Contributor

ps now that I've successfully done the work to enable contributions like yours from forks, it will be much easier for future contributions to be submitted, reviewed and merged in good time, I'm pleased to say 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Semantic versioning: backwards compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants