deps: update peerDeps to support React 17 without warnings #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- seems to work without any component modifications needed on React 17
- it was supposed to have "no new features" in any case
per the release blog post
- https://reactjs.org/blog/2020/10/20/react-v17.html
- ensure tests pass with React 17
- update devDeps to React 17 + react-dom 17
- update devDeps to use unofficial Enzyme Adapter for React 17
- official adapter has yet to be released, but this seems to work
for many people and the usage here is quite simple, so should be
fine for this use-case
- and tests seem to pass without issue too
- React 18 will be a separate story, but will cross that bridge
when we get there
agilgur5
added
the
scope: dependencies
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 59 59
Branches 6 6
=========================================
Hits 59 59 Continue to review full report at Codecov.
|
agilgur5
commented
Feb 9, 2022
Repository owner
locked as resolved and limited conversation to collaborators
Feb 27, 2022
agilgur5
added
scope: tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
peerDependenciesrange to support React 17Fixes #58
Closes #64
Description
seems to work without any component modifications needed on React 17
per the release blog post
ensure tests pass with React 17
for many people and the usage here is quite simple, so should be
fine for this use-case
when we get there
Review Notes
Had to do some manual things in the background like migrating and re-setting-up Travis (and emailing them about OSS credits etc) as well as making sure Codecov still works etc. Make sure everything passes here before merging!
Will PR and merge my old
standardizationbranch after this just to have less changes for this (less things to break). Those commits are like 2 years old now but still relevant. Will see about #42 after