Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change CI badge to use GH Actions instead of Travis #85

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

agilgur5
Copy link
Owner

Summary

Migrate the CI badge from Travis to GH Actions as well

Details

  • use the "CI" workflow on the main branch only

    • note that it is case-sensitive, so had to put the workflow name in caps for the badge to work properly
    • basically same as how the previous badge only reported on main
  • missed this one tiny detail during the migration

    • did a search this time to make sure I replaced Travis everywhere

@agilgur5 agilgur5 added scope: docs Documentation could be improved kind: internal Changes only affect the internals and not the API or usage labels Jun 11, 2022
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #85 (9e83201) into main (514dec0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           75        75           
  Branches         9         9           
=========================================
  Hits            75        75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514dec0...9e83201. Read the comment docs.

- use the "CI" workflow on the `main` branch only
  - note that it _is_ case-sensitive, so had to put the workflow name in caps for the badge to work properly
  - basically same as how the previous badge only reported on `main`

- missed this one tiny detail during the migration
  - did a search this time to make sure I replaced Travis everywhere
@agilgur5 agilgur5 force-pushed the docs-migrate-ci-badge branch from 2bb3225 to 9e83201 Compare June 11, 2022 02:53
Copy link
Owner Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. one-liner change and confirmed that the rendered version works

@agilgur5 agilgur5 merged commit 6ed1a63 into main Jun 11, 2022
@agilgur5 agilgur5 deleted the docs-migrate-ci-badge branch June 11, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals and not the API or usage scope: docs Documentation could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant