Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-30 Limitations on public access should reference the UK Regulations for allowable reasons, not just the EC Directive (John Dixon, Defra) #17

Open
PeterParslow opened this issue Mar 10, 2021 · 11 comments
Labels
Elements Issue that primarily affects the GEMINI elements enhancement New feature or request

Comments

@PeterParslow
Copy link
Contributor

The encoding should remain as per the European guidance, so referencing the items in the INSPIRE registry. But it would be helpful for a UK audience to see it in terms of the UK INSPIRE Regulations.
John has a mapping document.

@PeterParslow
Copy link
Contributor Author

See also #6

PeterParslow added a commit that referenced this issue May 21, 2021
Only the 'datasets.htm' page changes, but the way we currently handle versioning means that the date at the top of the services.htm page would also change.
@PeterParslow
Copy link
Contributor Author

"alignment of UK INSPIRE Regulations 2009 (The INSPIRE Regulations 2009 (legislation.gov.uk)) regulation 9 (2) and (5) to INSPIRE Directive Article 13(1)."

On leaving EU: https://www.legislation.gov.uk/uksi/2018/1338/regulation/10/made

@PeterParslow
Copy link
Contributor Author

John's suggested mappings are in this document (along with some stuff that's not relevant to GEMINI)
Data Sharing Assessment - INSPIRE Element Mappings - John Dixon suggested text.docx

@PeterParslow
Copy link
Contributor Author

I have created a branch version of this file which I think captures the spirit of what John Dixon wanted to see: https://github.com/agiorguk/gemini/blob/PeterParslow-issue-17/docs/partials/limitationsonpublicaccess.asciidoc

@nmtoken
Copy link
Contributor

nmtoken commented Nov 9, 2023

Looks good; should you also update the change history

@PeterParslow
Copy link
Contributor Author

"should you also update the change history" - I've been doing that with each pull request I create to DEV. This one is still in the 'do we agree' stage.

@PeterParslow
Copy link
Contributor Author

PeterParslow commented Sep 4, 2024

Note https://github.com/agiorguk/gemini/tree/PeterParslow-issue-17 was created to implement this, but GitHub won't let me actually link it

@archaeogeek
Copy link
Member

archaeogeek commented Sep 5, 2024

@PeterParslow did we agree to replace what we currently have with what's in your branch? Happy to do that, if so (as per comment on #61)

@PeterParslow
Copy link
Contributor Author

That's the way I read nmtoken's Nov 2023 comment and I think that was confirmed in yesterday's meeting. I (or you) should update the change log & turn my branch into a pull request.

Yesterday I was pruning branches that had already been committed to dev; I noticed that this branch hadn't - in fact, it didn't even have a pull request which I could have done at any point in the past 10 months. Are you OK to do that, @archaeogeek ?

@archaeogeek
Copy link
Member

@PeterParslow I've merged https://github.com/agiorguk/gemini/tree/PeterParslow-issue-17 into dev and deleted that branch. As per #61 I think the next step is to expand Guidance Note 7, so I think this issue can be closed?

@PeterParslow
Copy link
Contributor Author

I've created #175 to document the change; after that, I agree this issue can be closed (& moved to "PR merged to dev")

archaeogeek added a commit that referenced this issue Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elements Issue that primarily affects the GEMINI elements enhancement New feature or request
Projects
Status: PR merged to Dev
Development

No branches or pull requests

3 participants