Fixed the issue that when coreclr references a dll in a path containing special symbols, the path is garbled and causes reading failure.

[XUMUMI]

Fixed the issue that when coreclr references a dll in a path containing special symbols, the path is garbled and causes reading failure.

[agracio]

Could you give an example of the issue.

    <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
    <PublishSingleFile>true</PublishSingleFile>
    <SelfContained>true</SelfContained>

Should not be added to bootstrap.csproj and Edge.js.csproj, it is up to individual implementers to decide how they publish their C# assemblies.

Warning

Using member 'Microsoft.Extensions.DependencyModel.DependencyContext.Default' which has 'RequiresAssemblyFilesAttribute' can break functionality when embedded in a single-file app. DependencyContext for an assembly from a application published as single-file is not supported. The method will return null. Make sure the calling code can handle this case.

[XUMUMI]

The problem now is that after the release, users will not be able to run the program normally due to the lack of dependencies, and these dependencies cannot be run and called directly as portable programs; maybe I should open a separate branch for the later package modification.

[agracio]

Great example is https://github.com/agracio/edge-js-quick-start, you have control over .csproj behaviour and able to set those properties. But for core edge-js projects it should not be set.

And give an example of the issue for special character, will try to add test for it.

[XUMUMI]

special

Yes, you are right. The last submission is not well considered.

[agracio]

Could you give an example of the issue you are trying to fix, I want to create a test for it.
Is it something like c:\path\测试\my.dll

[XUMUMI]

Could you give an example of the issue you are trying to fix, I want to create a test for it. Is it something like c:\path\测试\my.dll

Yes, your example meets the requirements.

The simplest way to test this issue is by adding other Asian languages, such as Chinese, to the project path.
You can reproduce the problem by downloading the electron-edge-js-quick-start project on a Windows platform and renaming the project folder to electron-edge-js-quick-start-测试.

[agracio]

Should be done in a couple of days.

[XUMUMI]

Should be done in a couple of days.

Thank you for your hard work.

[agracio]

electron-edge-js v33.0.5 released.