Fix broken links to glossary items in user guide #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
docs-broken-glossary-anchors
branch
from
6435f56 to
93d862b
Compare
|
The failing test seems to be a flaky one? https://github.com/agronholm/apscheduler/actions/runs/8063354336/job/22024980072 |
agronholm
requested changes
Mar 1, 2024
docs/userguide.rst
Outdated
| them, and then sending back the results to the `data store`_. | ||
|
|
||
| Running the scheduler | ||
| ===================== | ||
|
|
||
| The scheduler_ comes in two flavors: synchronous and asynchronous. The synchronous | ||
| scheduler actually runs an asynchronous scheduler behind the scenes in a dedicated | ||
| thread, so if your app runs on :mod:`asyncio` or Trio_, you should prefer the | ||
| asynchronous scheduler. | ||
| thread, so if your app runs on :mod:`asyncio` or `Trio <https://trio.readthedocs.io/en/stable/>`_, |
There was a problem hiding this comment.
Just add a counterpart to this later (.. _Trio: https://trio.readthedocs.io/en/stable/). I dislike inline links.
agronholm
approved these changes
Mar 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some links to concepts/glossary in the user guide