Meta project fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to change the privacy of these; just need to have the symbols referenced within the staticlib crate.
to avoid linking failures as described in comment
ahayzen-kdab
reviewed
Dec 1, 2023
| @@ -202,10 +202,13 @@ endif() | |||
| set(CARGO_TARGET_DIR "${CMAKE_BINARY_DIR}/${BUILD_DIR}/cargo/build") | |||
|
|
|||
| # Add CMake tests for `cargo test/clippy/fmt/doc`. | |||
| add_test(NAME cargo_tests COMMAND cargo test --features link_qt_object_files --all-targets --target-dir | |||
| ${CARGO_TARGET_DIR}) | |||
| add_test(NAME cargo_doc_tests COMMAND cargo test --features link_qt_object_files --doc --target-dir | |||
There was a problem hiding this comment.
can --all-targets and --exclude not be combined? So that it does "all except qml-meta-project"
There was a problem hiding this comment.
Also this failed to build on Windows Qt 5 🤔
There was a problem hiding this comment.
--exclude only works with --workspace, not --all-targets
|
I've tried disabling parallelization in both CMake and Cargo... I think we've stumbled on a bug in rustc 😵 Why it only happens with Qt5, I have no idea... |
|
Fun, we might need to try on a real Windows system to see what is going on. |
|
Lets merge this into the branch so it's get visibility in the main repo... |
ahayzen-kdab
merged commit 77ced1f
into
ahayzen-kdab:592-multi-crate-project
5 of 6 checks passed
|
Okay. I'm not very inclined to use a Windows VM to figure out what's going on with that weird build error... so... 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.